zkapp-cli icon indicating copy to clipboard operation
zkapp-cli copied to clipboard

Discussion: Should the project template be a clone of a repo on Github?

Open jasongitmail opened this issue 4 years ago • 1 comments
trafficstars

As opposed to a using Gittar and creating a new Git repo.

  • Pro: This would allow devs to rebase using the latest recommended project & see what has changed.
  • Cons: Dev's repos would have more history, that they may not want--though a dev could delete .git and start from scratch if they wanted too, or could squash old commits. Cloning would be slower than degit. Degit is already set up with caching to work even offline too.

[ ] To do this, git clone instead of using gittar. [ ] Change project command to get project creation working offline again. [ ] And rename Git remote 'origin' to 'upstream'.

Given the downsides, I lean toward "no". We will have a check and fix command that will work, even if a dev created their own repo too.

jasongitmail avatar Jul 15 '21 06:07 jasongitmail

We also will have check and fix commands to help bring a project up to current recommendations. That might be better? TBD.

jasongitmail avatar Jul 19 '21 04:07 jasongitmail

Discussed with Yoni. Gittar has been working well, and we don't want to make this large of a change

jasongitmail avatar Jan 05 '23 19:01 jasongitmail