James M Snell comments

Results 691 comments of


                                            James M Snell

Create nodejs/standards-positions repository

Sounds reasonable. So far it is looking like there are no objections to setting up the repository but obviously let's let the requisite 7 days pass. Assuming there are no...

Create nodejs/standards-positions repository

After much delay, finally created :-) https://github.com/nodejs/standards-positions/blob/main/README.md

src: remove node namespace from sqlite.cc

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase

Problem flagging: how can we identify excessive amounts of scheduling?

The key problem is not scheduling ratio but too much scheduling of purely synchronous tasks. "Fake asynchronous"

🐛 BUG: "Module cannot be synchronously required" when using `@cloudflare/vitest-pool-workers`

This is still on the radar but fixing is very tricky. I do not have an current ETA yet.

collect data for a production process?

Currently, no. The reason is that in order to do the analysis Clinic.js needs, a *massive* amount of data is collected. For example, in one case I had a single...

Let's talk about the CI situation

> The CI is so flaky it's systematically takes several attempts to get a passing one. I've had PRs that have required 10-16 CI runs to get even a flaky...

fs.cpSync / fs.cp / fs.promises.cp fails when src/dest args are Buffer/URL

The immediately clear problem is this block in the `copyDir` function in the cp-sync.js file, specifically the two calls to `path.join(...)`. The `src` and `dest` here might be Buffer or...

fs.cpSync / fs.cp / fs.promises.cp fails when src/dest args are Buffer/URL

> The only reasonable way to implement this in a non-breaky way I think would be to always convert everything to strings, basically keeping the exact same (incorrect but also...

fs.cpSync / fs.cp / fs.promises.cp fails when src/dest args are Buffer/URL

To illustrate the problematic scenario here... most POSIX OS's treat file names as opaque byte strings with very few actual limitations. Generally, the only bytes that aren't allowed in a...