Jasmine Sun
Jasmine Sun
*[`pkg/sql/catalog/descpb/structured.go` line 303 at r2](https://reviewable.io/reviews/cockroachdb/cockroach/118546#-NqYMLLx93MW_TxgQ5Lr:-NqZJ7zpD05nMyYtiDCO:befx6sl) ([raw file](https://github.com/cockroachdb/cockroach/blob/8c72a80283e5057351ff80d20aea4db49e77b2d5/pkg/sql/catalog/descpb/structured.go#L303)):* Previously, rafiss (Rafi Shamim) wrote… nit: "it will return 1 if the both fields are 0" so should this be `&&` instead of...
*[`pkg/sql/logictest/testdata/logic_test/serial` line 400 at r2](https://reviewable.io/reviews/cockroachdb/cockroach/118546#-NrurFY7C1Sb8_oQWaq4:-NrvHUd62Wxwe8OlSt5N:b-tw491n) ([raw file](https://github.com/cockroachdb/cockroach/blob/8c72a80283e5057351ff80d20aea4db49e77b2d5/pkg/sql/logictest/testdata/logic_test/serial#L400)):* Previously, rafiss (Rafi Shamim) wrote… just curious, why did this test get removed in the latest patch? moved it to pkg/sql/logictest/testdata/logic_test/mixed_version_sequence_per_node_cache!
*[`pkg/sql/alter_sequence.go` line 157 at r8](https://reviewable.io/reviews/cockroachdb/cockroach/118546#-NrupZXH1jM30XOGKKm-:-NrvNTCbAJ9FT_jMr7_C:bgjaw0o) ([raw file](https://github.com/cockroachdb/cockroach/blob/26699e48e25de43cc50716b9ad0d63f608211271/pkg/sql/alter_sequence.go#L157)):* Previously, rafiss (Rafi Shamim) wrote… i may not follow this: don't we need to look at `option.IntVal` if the version is active? I...
*[`pkg/sql/schemachanger/scbuild/internal/scbuildstmt/create_sequence.go` line 76 at r8](https://reviewable.io/reviews/cockroachdb/cockroach/118546#-NruqLC55eieHdKkJDOo:-Nrvb8TlELAttC6pm7yA:bhuqrt4) ([raw file](https://github.com/cockroachdb/cockroach/blob/26699e48e25de43cc50716b9ad0d63f608211271/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/create_sequence.go#L76)):* Previously, rafiss (Rafi Shamim) wrote… does this code need to use the value of `opt.IntVal` if the v24.1 version is active? same as...