Jasmine Karthikeyan
Jasmine Karthikeyan
Closing for now. Please re-open if there are additional details.
Thanks for the reviews! /integrate
Should be fixed with [d75fd5f](https://github.com/Vineflower/vineflower/commit/d75fd5f73c4406786b82e347e7a9fd3d09401bce). Thanks for the report!
I think you may need to rebase off of 1.12.0 for this, the diff and history have been pretty mangled. Thanks!
@eme64 I've pushed a new version that implements widening, as well as modifies the unit tests to use the new `Generators` framework. I've also filed [JDK-8349562](https://bugs.openjdk.org/browse/JDK-8349562) as followup work for...
I also updated the benchmark, and got these results: ```c Baseline Patch Benchmark (SIZE) Mode Cnt Score Error Units Score Error Units Improvement VectorSubword.byteToInt 1024 avgt 12 185.700 ± 0.798...
@eme64 I think it should be good for another look over! I've addressed your review comments in the last commit. About the potential for performance degradation, I think it would...
@eme64 Apologies for the delay! I've updated the patch to use `VectorCastNode::implemented` as suggested instead of manually implementing the logic, which simplifies the patch and provides implementations on other platforms,...
@eme64 Thank you for the comments! I've updated the test and benchmark to be more exhaustive, and applied the suggested changes. For the benchmark, I got these results on my...
Thanks a lot for running the benchmark on your AVX512 machine! The results are very interesting, in the char cases it looks like we over-unroll the loop with SuperWord enabled...