Jasmine Karthikeyan comments

Results 107 comments of


                                            Jasmine Karthikeyan

8342662: C2: Add new phase for backend-specific lowering

@eme64 Thanks a lot for looking at the PR! You're correct, `identify_useful_nodes` does add the whole graph. Having a worklist would indeed be better, but the problem I ran into...

8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly turncated for byte and short

Thanks a lot for your review @eme64! I've pushed a commit that should address the reviews, and fix the GHA failures. I've added char tests as well. Regarding long operations,...

8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly turncated for byte and short

@eme64 Thank for taking another look! I've pushed a commit that adds an assert so that we can detect when unexpected nodes pass through the truncation filter. BTW, how did...

8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly turncated for byte and short

@eme64 I've updated the patch to address the comments, let me know what you think! @mur47x111 Thanks for the comment! I've merged from master.

8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly turncated for byte and short

@eme64 Thanks for the test results! I've added these nodes to the non-truncating list, as well as the other reduction nodes that showed up when running the vector tests.

8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly turncated for byte and short

@eme64 Thanks for running it again! I've pushed a fix for the `ExtractB` assert, and a proactive fix marking any nodes with `TypeVect` as their base type as non-truncating.

8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly turncated for byte and short

@TobiHartmann @eme64 Thanks a lot for the testing and re-reviews! I've fixed the PR title and will integrate it. /integrate