Jeremy Ashkenas
Jeremy Ashkenas
A ha. This was an intentional change: I'm of the opinion that BSD (and Lil, and MIT) already include the superset of what "sublicense" is intended to do in MIT....
I also got a tip to check out Robert Pierce at: https://www.elcaminolegal.com/
I fairly strongly feel like Underscore shouldn't try to introduce a new system for doing OOP-in-JS, elaborated on a bit here: https://github.com/jashkenas/backbone/issues/4245#issuecomment-999259553
Switch on bind does look slightly preferable. Creating a new switch/case pyramid of doom would be distasteful, even more so if it puts an upper limit on the number of...
> I'm not actually sure this should be merged. Is using a bound function as a constructor important to support? It is not important to support. Within a constructor function,...
> So where to take this: > > * Support some constructors but not others (current situation)? > * Support all constructors (this PR)? > * Support no constructors at...
Would certainly be worth exploring in a pull request. Would it really be so much code? You couldn't put the iteration logic in a single function? ES6 `for of` is...
I’d be happy to defer to whichever version you think is best for this, because I don't have a particularly strong opinion about how this should behave, in the context...
Thanks for laying out the tl;dr of the four options. It sounds like it might be time to have "the big semver conversation" if we go with option 4...
I think you’ve all arrived at very reasonable conclusions here. Special casing `isEqual` for object identity comparison for Errors specifically seems like a nice improvement to make. To the larger...