jasells comments

Results 36 comments of


                                            jasells

Collecting code coverage prevents all test discovery on net472 only

I am seeing a similar issue. MS's coverage collector in VS enterprise/test sees the coverage just fine, but coverlet is "blind" to all coverage that should be available from a...

Collecting code coverage prevents all test discovery on net472 only

OK i have a repro [here](https://github.com/jasells/MissingCoverlet.Repro.Tests). It may deserve it's own issue, since it is .NetStnd and involves a 3rd party lib: [NetMQ](https://github.com/zeromq/netmq). But, the symptoms are the same.

Collecting code coverage prevents all test discovery on net472 only

> OK i have a repro [here](https://github.com/jasells/MissingCoverlet.Repro.Tests). It may deserve it's own issue, since it is .NetStnd and involves a 3rd party lib: [NetMQ](https://github.com/zeromq/netmq). But, the symptoms are the same....

Collecting code coverage prevents all test discovery on net472 only

> If anyone else is experiencing this, this link may help to use MS's collector in your pipeline to collect coverage data. This is my plan B. > https://medium.com/swlh/generating-code-coverage-reports-in-dotnet-core-bb0c8cca66 FYI,...

Collecting code coverage prevents all test discovery on net472 only

will do.

Poller will throw ObjectDisposed exception if Socket.Dispose() called

I created a fork to repro by adding a new unit test [NetMQPollerTest.RemoveAndDisposeSocket()](https://github.com/jasells/netmq/blob/3b8dbb929f76046852c5eb88b5869f0fed3fdbe5/src/NetMQ.Tests/NetMQPollerTest.cs#L464). This test as-is will never complete, as the exception kills the test execution, and there is no...

Poller will throw ObjectDisposed exception if Socket.Dispose() called

I made branch [here ](https://github.com/jasells/netmq/blob/taskFix/src/NetMQ.Tests/NetMQPollerTest.cs)with a potential fix. I refactored ```NetMQPoller.Remove(ISocketPollable)``` to return a ```Task``` instead of ```void```. This allows for proper thread syncing of the async ops needed to...