Jasbir

Results 10 comments of Jasbir

@OlgaMaciaszek, I will be happy to contribute. I will start working on this next week, expect PR soon.

@OlgaMaciaszek here is PR https://github.com/spring-cloud/spring-cloud-openfeign/pull/766

@OlgaMaciaszek implemented logic for URL as per the above discussion.

> Thanks a lot @jas34. This PR is nearly ready for merge. I have added some minor issue comments to the documentation changes, but will also request @Buzzardo to review...

@OlgaMaciaszek if this is still needed to be worked upon then I would like to work on this.

@OlgaMaciaszek I can see: 1. `socketTimeout` is already existing in https://github.com/spring-cloud/spring-cloud-openfeign/blob/07ded06f73f62ea2b74ad096db31ce2cab873f4d/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/clientconfig/HttpClient5FeignConfiguration.java#L81 2. `connectionRequestTimeout` was added in PR https://github.com/spring-cloud/spring-cloud-openfeign/pull/817 I do not think anything is needed against this ticket. Let me...

As I am currently occupied with other projects, there are no immediate plans for the same. However, I would not mind if you would like to contribute.

> > Apart from inline comments, the following are the general comments: > > > > * Add author in new files as well as add @SInCE. > > *...