James Henderson

Results 87 comments of James Henderson

apologies, seen the failing build, will check

Oh, wow, can only have one `(Class/forName ...)` in an `extend-protocol`, and it has to be first - TIL. That'll teach me to 'just' swap them over!

Ah, sorry @benedekfazekas - I don't think we can just filter out `clojure.lang` like this: * We don't want to rename `clojure.lang.Var` etc - these are in the standard Clojure...

Ah, sorry, took me a while to repro given my above description too :sweat_smile: * `^:inline-dep [clj-tuple "0.2.0"]` * `lein inline-deps` (using a `mranderson` version without the explicit `clojure.lang` exclusion...

Will require an index-version bump to fix properly, at which point we'll need to: * store the doc-consumer offset in the LDS rather than the index-store * update the checkpoints...

Remembered that we need to set up and deploy a cruxbot GPG key to sign the releases with...

It's now running on sorted maps, needs to work for the larger ingest tests

That's weird, EDN shouldn't be order-specific! My initial thought would be that, depending on the size of the map, Clojure sometimes opts for an ArrayMap like implementation, sometimes a HashMap....

Thanks @tkovis - likewise, I haven't been able to repro it, but will keep it on the radar in case others can :pray: