Jarek Danielak comments

Results 77 comments of


                                            Jarek Danielak

Loss of duration when changing timer start events in event sub process

It's a bit of a rabbit hole. 🐰 ### What happens? 1. Replacing a Timer event with non-interrupting and vice-versa triggers [CopyPasteBehavior#canHostTimerExpression](https://github.com/camunda/camunda-bpmn-js-behaviors/blob/cc5d7422900150f409cc46250af92e1cc26bed8d/lib/camunda-cloud/CopyPasteBehavior.js#L70) from `camunda-bpmn-js-behaviors`. 2. It uses `isTimerExpressionTypeSupported` utility to...

Loss of duration when changing timer start events in event sub process

I created a new issue for event not changing from non-interrupting to interrupting at all, cause it seems to be unrelated to the Duration property loss: https://github.com/bpmn-io/bpmn-js/issues/2344

Loss of duration when changing timer start events in event sub process

I added test cases to catch this bug in `camunda-bpmn-js-behaviors`: https://github.com/camunda/camunda-bpmn-js-behaviors/commit/1d820ee863860d9798625500448cb12af8c97acd

Loss of duration when changing timer start events in event sub process

More root causing: `BpmnReplace` calls `ModdleCopy#copyElement` with `newBusinessObject` which has no parent. `ModdleCopy#copyElement` tries to copy properties, calls `moddleCopy.canCopyProperty` event, which is picked up by `CopyPasteBehavior`. `CopyPasteBehavior` checks if each...

Loss of duration when changing timer start events in event sub process

Possible solution: We have another behavior `CleanUpTimerExpressionBehavior` which is called on `postExecuted` of `shape.replace`, which handles clearing unsupported properties. We could make `CopyPasteBehavior` less strict for TimerEvent (not check for...

Template support for UserTask definitions

@yT0n1 allowed `zeebe` properties and their bindings are indeed "whitelisted" (explicitly described) in the JSON schema, in [properties.json](https://github.com/camunda/element-templates-json-schema/blob/979b52c2aafe642e515f2cf85113e0020e731940/packages/zeebe-element-templates-json-schema/src/defs/properties.json). If you're not comfortable reading the schema (few of us are), have...