Henning Janssen
Henning Janssen
@sphuber Thank you for your feedback. I appreciate your point that these kinds of serializations/deserializations have to be more high level in order to ensure consistency. If I understand you...
Thinking about this more I agree that the location for this serialzation/deserialization layer is not very clear. My thought was that it would be on the same layer, where `clean_value`...
@sphuber I wrote a PR with a higher level deserialization #5614. This still has problems with the abstraction, especially when it comes to the `QueryBuilder` but it is a step...
@ramirezfranciscof I would be happy to try to create a PR for this. I had a short look into this yesterday and probably somewhere the json serializer has to be...
I just checked back here and I see that the PR mentioned by @chrisjsewell is now merged. If only the serialization would be supported via `clean_value` like @sphuber suggested, I...
@sphuber I understand your point, the complex numbers should not mess up unrelated cases. The idea I thought of, but did not write down in this issue so far, was...
@bosonie @sphuber I, unfortunately, cannot request a review directly so I'm pinging here. I think to request a review I also need to be approved first.
I want to add one additional thing that I noticed when looking back over the code yesterday. In all cases where a deserialization would be inserted the return value is...
@sphuber Thanks for the detailed answer. Would be happy to discuss today how we could get this into aiida-core 👍