jansol

Results 348 comments of jansol

The rayon solution is mostly meant as an "easy" API, but it did occur to me that the rayon-specific code might really belong into the cli rather than the library...

I was planning to start by transcribing the MIT/PD [bc7enc](https://github.com/richgel999/bc7enc) for BC7. For BC6 the best starting point is probably [bc6h_enc](https://github.com/0xc0de/bc6h_enc). Alternatively [bc7enc_rdo](https://github.com/richgel999/bc7enc_rdo) could be worth a look for all...

Hmm, not sure how to actually do that? Either way, adding a `#![warn(rustdoc::missing_crate_level_docs)]` and possibly other relevant attributes sounds like a good idea.

I haven't been entirely happy with the API myself either, but haven't had the time to properly think about what I would prefer it to look like. One major issue...

Sure, go ahead. It is probably easiest to evaluate the options by seeing what they would look like in practice anyway. I also plan to add a Bc1Alpha variant since...

As far as I've seen usually, there is a separate AlbumArtist tag that is used for the album itself, regardless of whether it is flagged as a compilation. Each individual...

I'd argue that compilations with inconsistent `AlbumArtist` are simply mistagged or the files are pulled from different albums and just slapped in a folder together for convenience. In general I'd...

https://wiki.hydrogenaud.io/index.php?title=ReplayGain_2.0_specification contains a nice implementation guide with both the math and the metadata format & tag names. It's a proposal for version 2.0 but the implementation on the playback side...

Looks like vale-ls is panicking: (see `debug: open language server logs` command in zed command palette) ``` initialized! configuration changed! stderr: thread 'main' panicked at src/server.rs:318:61: stderr: called `Option::unwrap()` on...

Assuming the syntax errors are correct it would be nice to show them already, even if they lack type checking etc. Any diagnostics are better than no diagnostics.