Jan Siegel

Results 21 comments of Jan Siegel

After https://github.com/handsontable/handsontable/pull/9441/commits/7a401acfc7be5a23a92e5f21cf74ef45c66db0ac the "Docs Staging Deployment" workflow started failing.

> @jansiegel is it going to be reviewed? Sure, but it was put on hold to finish the React-Docs project and now it's not in the scope of `12.2`.

> @jansiegel is this PR, in your opinion, such a turning point for the React wrapper? @warpech If I understand correctly, this problem exists only for the newer versions of...

@kirszenbaum I think everything apart from https://github.com/handsontable/handsontable/pull/9752#discussion_r942136240 should be covered in https://github.com/handsontable/handsontable/pull/9752/commits/9472ce9a8f643a6faee3ec17163b636b5e7d0f7d and https://github.com/handsontable/handsontable/pull/9752/commits/e90ec34bae5e8a1333beabf05b42012fa248169c.

Notes to the code reviewer (@wszymanski): 1. It'll be easier to test after https://github.com/handsontable/handsontable/pull/9384 is finished. 2. Testing this requires doing some workarounds: - Symlinking the `public/scripts` directory to `dist/docs`...

@wszymanski > Thus, please make me the reviewer then. You are the reviewer on both of these PRs

@wszymanski > The script shows errors for every example for me (red dots). I run, for example `node .vuepress/tools/check-examples 12.0` for already updated branch. Maybe I'm doing something wrong? Have...

> I've rechecked PR again ... I broke some examples, but after executing the check script, I haven't got any errors. Can you check that? > > In Javascript, I...

@budnix, after the changes in https://github.com/handsontable/handsontable/pull/9440/commits/3a083559963acc2eddc116d89f02e56b43178fb6 the issue with typos in `Handsontable`/`HotTable` should be covered as well (in most cases, anyway - when the example container contains a single HOT...