Jan Pipek

Results 61 comments of Jan Pipek

Hi, I probably won't include any of your code in `physt` (at least for now). The main purpose is that I want it to remain a simple tool without any...

P.S. According to your references, seems you're coming from a similar background ;-)

Practically, the following plot shows how lengthy (in microseconds) is to process each of the 3000 records in a file (all of them are of similar complexity). ![unoptimized](https://user-images.githubusercontent.com/92804/63771540-a697c980-c8d7-11e9-88f8-c6d83d7c76a6.png)

An unclean hack-until-the-code-works-in-your-specific-Python-version-for-your-concrete-example-file style solution is implemented in https://github.com/janpipek/pyasn1/tree/naive_bytesio_attempt . I don't consider the code ready or correct or anything, it would take days to make sure everything is right...

Hi, thanks for the comments. I made some effort to implement the ideas correctly (passing most tests but one functionality I am not able to deal easily with), see PR...

Not too optimistic yet... ![benchmark1](https://user-images.githubusercontent.com/92804/63946938-51de8500-ca76-11e9-96ac-96392e600641.png) I will think about it...

Hi Ilya, thanks for the comments and for the detailed code review. I hope I will get to another attempt at the beginning of the week.

Hi Ilya, after another two re-implementations (currently in https://github.com/janpipek/pyasn1/tree/new_stream_implementation - later, I will merge this into the PR), I am getting to more comparable results: ![image](https://user-images.githubusercontent.com/92804/64403787-2a8d4680-d07a-11e9-927e-ef96accca64c.png) I have still a...

And... after a few more optimizations, I actually got to being slightly faster for all but the most simple boolean example with Python 3.7 at the price of (still) pre-reading...

Note: I was not able to test against the pyasn1-modules (master) because of: ``` tests/test_rfc6211.py:18: in from pyasn1_modules import rfc6211 pyasn1_modules/rfc6211.py:51: in constraint.WithComponentsConstraint( E AttributeError: module 'pyasn1.type.constraint' has no attribute...