Jannis Born

Results 37 comments of Jannis Born

@kexinhuang12345 @futianfan - I tried to merge the work from #167 into this PR. - I debugged with 3 sklearn versions, 0.23.0 (which was stable already before), 0.24.2 (broken up...

Hi @futianfan Should be done now! you can delete your `sklearn_merge_168_167` branch, it's integrated here

Thanks! it would be really great if you could release a new version :) Then we could update our TdC dependency to that version and relax sklearn

HI @kexinhuang12345, any updates on this?

Hi Kexin, thanks for the rapid feedback. No it's not super urgent, we were hoping to integrate some more TdC oracles (the ones affected by this PR) into our library...

Thanks a ton Kexin, much appreciated 👍🏼

Completely agree with you @linminhtoo! We actually tried to emulate `sklearn.svm.classes` in newer sklearn versions with tricks like: ```sh sys.modules["sklearn.svm.classes"] = sklearn.svm ``` After this hack, the `pickle.load()` command runs...

Hi all, I sketched a draft PR here: https://github.com/mims-harvard/TDC/pull/168

Ah sorry, that's on me, I should have synced with you before drafting the PR Let me try to integrate both things, it looks straightforward