Jann Fischer

Results 216 comments of Jann Fischer

@wparr-circle I took a look at the PR in your fork, and I also like that change better than the original. It's much simpler and easier to read. > However,...

Thanks! Just a small request: Can you please put it in the right alphabetical order, i.e. after pismo?

It sat for a while and received no request for changes.

> Is there a public test image I can use to try it out? I'm afraid there's not, sorry. We usually don't build images for PRs at this stage. But...

Thanks, that's some valuable feedback @ellakk! I gotta dig into this, it's probably the dependency graph being build too often.

Sorry for being so late to the recent comments. @riuvshyn I haven't tested it with ApplicationSet, but ff you define one or more dependency selectors in an ApplicationSet's Application template,...

Thank you so much for testing again, @ellakk. Actually, I have not changed anything I thought was performance related, so potentially the iteration of the PR you tested was against...

I think this is good to go for the first iteration. The only remaining question imho would be: Should this feature be behind a feature-flag or not? cc @crenshaw-dev @alexmt...

@jsoref Thanks for that thought. But I was wondering, how would you play with that feature on a read-only public instance?