Jann Fischer

Results 216 comments of Jann Fischer

Hm. Did you make changes to the CRD recently to move from namespaced to non-namespaced? Figuring that the prune happened against revision `9b9ff97b11d83373bdd4d05fadcf20c791e5600e`, have you had a look at repository...

Awesome! Do you mind adding some pieces of examples to the docs as well?

Sorry for the late reply. The suggestion from @jwhy89 is correct. The spell checking is non-critical though, but the DCO actually is. Can you please ensure that your commits are...

Just as a heads-up, there is #18028 as the candidate to fix #17634 I will take a look at this PR later in the day :)

I think this would be useful. However, I have a slight concern about using both, labels from `Application` and `AppProject` here. If both, `Application` and `AppProject` have a label with...

As long as this behaviour is documented, I'd be fine with labels on the Application to override labels from the AppProject on the emitted events.

I was wondering though, what ends up on the events should be _annotations_, not _labels_, right?

Reading through this issue, I think this bug affects only plugins that use kind of `git` integration themselves, right? E.g. those which need access to Git _after_ Argo CD has...

Thanks for bumping this @bn-cforkner , I'm currently going through the backlog of PRs and issues. I'm really sorry to have been undercover for a while. Couple of the changes...

How about `oci-toolkit`?