Jann Fischer

Results 216 comments of Jann Fischer

Thanks for this PR @djeebus - looking forward to get this merged! > Some of it was just to clean up what I was looking at, maybe a bad habit...

> I thought about having an annotation without the alias to specify one application-wide default. Sounds great. I like the idea! > Maybe I find some time during my xmas...

@janpieper-gcx Will you send that PR? I favor merging yours over the one I've created and will keep the one I've sent unmerged for a while.

Hey @janpieper, thanks for coming back to it and no sweat. I was just unsure whether you'd send a PR or not, so I hacked something together because what you...

Oops. Good catch, thanks for calling that out. I believe we must have forgotten to remove the first statement once the feature to re-use Argo CD credentials for Git access...

Thanks for that link, @iam-veeramalla, it's a great summary. And sure, I think it's a great idea to explore possible other options. I'm only a little opinionated on `testify`, since...

First chunk of migration to `stretchr/testify` can be seen in https://github.com/argoproj-labs/argocd-operator/pull/437

To chime in here, having the possibility to treat the test YAMLs as templates, with some variable replacements, would be much beneficial for writing re-usable and easy to construct test...

Just bumping this one up. Could maintainers please take care to add a security policy to this repo? Thanks!

I agree that this error message isn't particularly helpful at all, and I believe there are quite a few more places that provide an experience similar to this one. Thanks...