Unclear description about re-using git credentials from ArgoCD

[janpieper]

Describe the bug

By reading through the documentation, I stumbled upon an unclear description about whether the image updater will re-use the git credentials configured in ArgoCD or not.

To Reproduce

https://github.com/argoproj-labs/argocd-image-updater/blob/195c758c2699838390684e2acac71e0ec60eff21/docs/configuration/applications.md#L139-L140

vs.

https://github.com/argoproj-labs/argocd-image-updater/blob/195c758c2699838390684e2acac71e0ec60eff21/docs/configuration/applications.md#L164-L165

Expected behavior

Be more clear.

Additional context

None

Version

Irrelevant as this is docs related.

Logs

None

[jannfis]

Oops. Good catch, thanks for calling that out. I believe we must have forgotten to remove the first statement once the feature to re-use Argo CD credentials for Git access was introduced.

[rscottwatson]

I am not sure which one is true as I was having problems getting my repo to update and in an effort to try and get things to work I added a repository credential and it didn't fix my problem. After looking around I came across this https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/2.0-2.1/#replacing-repositories-and-repositorycredentials-with-secrets.
Which seems to imply that the credentials in the config map are now deprecated.

In my case, my overlay was not being updated because I had to create the git secret in the argocd namespace and not the namespace where I had my deployment. ie. git:secret:argocd/git-creds worked but git:secret:default/git-creds. Did not work.