janluak

@simonpasquier is there already existing code for the other crds checking the singularity? Then I'd reuse it... I tried to write a scrape config with explicitly trying to relabel but...

> Regarding the implementation, I wouldn't change the value of `job_name` but rather add a relabeling config to inject the `job` label when `.spec.jobName` is set. This way we wouldn't...

So I played around again with the relabel config and implemented it now with the relabel config. Still, for some reason I cannot get my head around this issue: The...

> Nice solution that you two found! > > My initial idea was to iterate over all selected *Monitor resources and make sure we don't have a matching job name....

> @janluak you'd need to rebase on top of main to resolve the conflict + address @ArthurSens comments. @simonpasquier thanks for your fix :) I rebased and implemented the type...

Hi Arthur,Sorry, I was quite busy the last days…Yet, I don’t really have an answer how I revert a rebase. I was thinking of renaming the branch and creating a...

Thanks for the quick reply @slashpai ! Totally understand the alpha state but was curious... Is the additional field a lot of effort to get the JobName just like in...

if you give me a little guidance (are there tests for this kind of stuff and is there some code doing the mapping by hand or is the actual scrape-config...

Hey guys, thanks for the quick heads-up for enabling me to do the changes. I just created the MR #6153 for the fix. It is only focusing on the `ScrapeConfig`....

So for `scrapeConfig` it's `.spec.jobName` and for `ServiceMonitor` and `PodMonitor` `.spec.jobLabel`? should the jobName get changed to jobLabel as well? I also found another inconsistency: the `.spec.scheme` is lower-letters in...