Janko Marohnić

Results 184 comments of Janko Marohnić
trafficstars

Sorry for the wait, I just haven't been finding the energy for Shrine. This change looks good and useful, I'm merging 👍🏻

Yeah, I noticed that you are using the nonblocking API, as opposed to the more primitive ```rb stdout_reader = Thread.new { stdout_pipe.read } stderr_reader = Thread.new { stderr_pipe.read } ```...

> Concurrent chunk uploading is not going to be supported by the TUS implementation, because as far as I see the TUS protocol has no concurrent support. After some digging,...

It would be nice if omitting one dimension would automatically resize just by the other dimension, rather than the dimension default being a square. That would be ideal because it...

@jcupitt That's perfectly reasonable, thank you!

Just FYI that [shrine-cloudinary](https://github.com/janko-m/shrine-cloudinary) supports responsive breakpoints 😃 https://github.com/janko-m/shrine-cloudinary#responsive-breakpoints

The generic command-line options that vim-test supports are inserted in between the filename and the executable. One way to pass them is via vim-test provided commands like `:TestNearest`, so you...

I'm not sure I understand yet what exactly vim-test needs to do here, but if any feature request that would otherwise require overriding the `:Test*` commands I would consider to...

So, this will only work if the user is using projectionist.vim and has it configured? I'm ok with that. If the user doesn't use projectionist.vim, we can just fall back...

Just wanted to note that regardless of projectionist, we should still have an implementation that doesn’t rely on it.