Janko Marohnić
Janko Marohnić
I initially added the limitation, but it turns out that when using the `FileInput` plugin, the `maxNumberOfFiles` option doesn't only limit the amount of files you can upload in one...
I agree, that is a good idea, it would give more value to the implementation, I will get working on those.
I decided that adding and maintaining tests for the example app isn't worthwhile. Mostly because I find writing end-to-end tests slighly PITA. Also, since I would have to communicate directly...
The official demo app has an [acceptance test](https://github.com/shrinerb/shrine/blob/b1e5d8362a8204e287d1609b580ccb90f8f009d6/demo/test/acceptance_test.rb), would something like that suffice? (just that we port if over here)
This is actually how Ruby's `File` class behaves, it returns content in binary encoding when you want to read a certain amount of bytes: ```rb file = File.open("Gemfile") file.read.encoding #=>...
> This suggests that my PR needs changes to match the IO behaviour. Do you agree? I really appreciate your research into this. Yes, I agree `Down::ChunkedIO#gets` should match Ruby's...
Could you write a self-contained example that reproduces the problem? Does it happen only when used with `Shrine::Storage::S3`, or can you reproduce it with vanilla Down (without Shrine)?
Hmm, is there a file I can test this with? Timeout errors should usually be problems with the server, or with the client not setting timeouts high enough (which is...
I believe Down uses HTTP 1.1, because AFAIK neither net/http nor http.rb clients support HTTP 2. I would like to add a [HTTPX](https://github.com/HoneyryderChuck/httpx) backend in the near future, but I...
Just pinging @HoneyryderChuck to let him know there is an interest in the HTTPX backend for Down 😉