Janko Marohnić

Results 159 comments of Janko Marohnić

I realized that this is a too specific use case, I just got around it in Shrine by overriding `Disposable::Twin.create_accessors`.

I appreciate you working on this, sorry that it has slipped off my radar. From a glance it looks good, I'll take a closer look in the upcoming weeks.

@vanboom When Shrine internally opens an uploaded file, it switches `#size` to read from that file, so that metadata extraction could get the actual filesize. When the uploaded file is...

It would appear that it might get overwritten [here](https://github.com/shrinerb/shrine/blob/f99fe7d10ed4c276d5afdca46194bc3ac9c76b95/lib/shrine/storage/s3.rb#L85) when copying the cached file to permanent storage. You should be able to use the `upload_options` plugin to set the attachment...

The code you posted looks like it should correctly set `:content_disposition` to attachment. Are you able to reproduce this behaviour with AWS S3? It's possible this is an issue with...

Thanks for reporting, I agree this is a security issue. My first thought is that we should disable IDs for filesystem storage from referencing files outside of the storage directory.

Hmm, that's a tough one. The entity plugin passes down arguments from the model method to `Attacher#get` because the derivatives plugin overrides `Attacher#get` with the ability to accept arguments. Technically,...

Setting `log_subscriber` to `nil` doesn't disable instrumentation, it only disables the subscriber that listens on events and prints them out. The instrumentation is useful in itself, because it allows other...

> What would be the best way to get just the logging provided by the instrumentation plugin, but without an instrumentation subscriber? You can't currently, the log subscriber receives an...