Janko Marohnić

Results 184 comments of Janko Marohnić
trafficstars

If not, I think it would be nice to show this example in the README, so that people are more willing to copy-paste it into their projects.

Hey @satazor, thanks for a quick answer. > Having a method to read files and calculate the hash out of it would have to cater how to really read the...

Both of these requires _should_ work 🤔 You can see that both of these files exist in the lib/ directory.

This proc is evaluated every time an URL is requested, it should change when the `Item#id` changes. Can you show me an isolated example where it doesn't change? Also, you...

I agree with everything you said. - The defaults are not working because I had to maintain backwards compatibility with these proc versions of paths. I didn't want to, but...

Since I don't use Paperclip anymore, I don't have the time/will to fix these things. I have tried to keep the code pretty and maintainable (although tests could be better),...

Apologies, I meant to open this on the `activerecord-jdbc-adapter` repo.

Yes, the old tracing API calls the `.trace` method, which remained unchanged in this PR. This PR just adds new methods that will be used by the new tracing API.

I tried reproducing it locally, but unfortunately I cannot `bundle install` with JRuby 9.2 on my MacBook M1, I'm getting the following error: ``` NoMethodError: undefined method `request' for nil:NilClass...

Thanks for the PR, and sorry for the delay. The implementation looks good to me, would you mind adding documentation to `docs/minimagick.md` and `docs/vips.md`?