Janicklas Ralph

Results 11 comments of Janicklas Ralph

Hi @vladimyr . Thanks for the PR! Just wondering if there is a need to export URL and URLSearchParams, since we are proving methods around it? Also URL and URLSearchParams...

Sorry about the late response! Thats a very valid point. Let me check out and test the changes before merging this

The exports are the same as the default [`node-url`](https://github.com/defunctzombie/node-url/blob/master/url.js#L27-L30) library which webpack uses when bundling for client I'm assuming everyone developed their libraries based on `node-url`'s export interface (which is...

The main reason for not using `URLSearchParams` is because it's not supported in Edge 16. Since Edge 16 supports `type=module` scripts [our polyfilling technique](https://github.com/GoogleChromeLabs/native-url#polyfill-for-older-browsers) would not work. So I'm not...

Can you give me some more context on when you would have lazy loaded CSS? It would seem easier to just let critters make that change

This could be a breaking change since users might be expecting a certain behavior. Maybe we can rethink the `fonts` flag? Remove it given the confusion and also the additional...

Do you know what selector is throwing this error? Some selector in the form `legend+*`. It would be helpful to test if you gave me the entire selector/rule

That makes sense to me. Could you open a PR with those changes and I can merge

I've made some changes in v0.0.19 to help with improving the speed of processing. It's a combination of adding a cache and also some user intervention. Please try this version...

Yes, the library rounds the values so we see very small change in the values. I didn't notice any changes in my tests.