Jan Hoffmann

Results 31 comments of Jan Hoffmann

> Adrian wrote a useful comment. This patch can be resent as a patch only to the parser. The most recent version of the patch, which splits it up into...

I think this should include a version bump for `ltq-adsl-app`, as that package copies `dsl_cpe_ubus.c` from `ltq-vdsl-app`.

> The autogenerated resolv files got moved into the `/tmp/resolv.conf.d/` for exactly this reason, so that jails can bind mount the parent directory. This works for dnsmasq as it is...

You need to properly handle scaling for the SNR data, as the group size isn't always 8. There is a maximum of 512 subcarrier groups, and the group size depends...

Scaling in x-direction looks good now: [vdsl2-35b.png](https://user-images.githubusercontent.com/949763/181818207-76d8b96c-86eb-4ae7-8016-964dc13cbe67.png) In some cases, the x value range may not be the same for each graph and the graphs don't align (but it isn't...

> @janh, are you sure regarding the value translation? Reading the ITU recommendation: > > ``` > 7.10.9.3 Downstream QLN(f) (QLNpsds) > ``` This seems to be from G.997.2, which...

In my opinion there is no need to draw missing values in a special way. For xDSL there is only a single special value anyway, which doesn't tell why the...

Something went wrong with your latest commit, it contains conflict markers.

It doesn't work properly here, there is an exception when drawing downstream SNR for VDSL2 profile 35b (looks like the code assumes a group size of 8 there): ``` Looking...

All four graphs are now working here.