Jan

Results 241 comments of Jan

update: ruff does not do type checking, so we do need `pyright`. Task for the PR solving this issue: - change `pyproject.toml` to depend on most recent `pyright` version, i.e.,...

To solve this issue: - check out https://github.com/pytorch/pytorch/issues/89127#issuecomment-2579000927 - reproduce locally dependent on the torch version - change the test to be dependent on the pytorch version, using `pytest.mark.xfail(condition=..., reason=...)`

I am also in favour of the first option.

Closing this as it is just a backup for the paper figure.

Thanks for the clarification. Then this is related to the recent question here: #1223 and we will fix this when we fix the general handling of custom potentials.

@Baschdl can you confirm this problem with PyCharm?

There are still changes in the notebooks if I look at the diff. But the notebooks should be changed by this PR, should they?