tests are failing because of new pyright release.

Open janfb opened this issue 2 years ago • 3 comments

there seem to be new checks in the pyright release that lead to pyright failing in our workflow.

The latest commit on main was tested with pyright v1.1.304. the newest version is v1.1.313.

Jun 12 '23 13:06 janfb

solution for now as proposed in #848 : pin pyright to last passing version and fix type issues before the next major release, or when changing to nflows.

Jun 13 '23 14:06 janfb

idea: change to ruff to handle type checking more flexibly: https://docs.astral.sh/ruff/

related to #928

Feb 09 '24 11:02 janfb

update: ruff does not do type checking, so we do need pyright.

Task for the PR solving this issue:

change pyproject.toml to depend on most recent pyright version, i.e., remove the pin.
execute pyright sbi tests locally and fix the errors or comment in the PR if not fixable.

Feb 27 '24 16:02 janfb