Jan Domański

Results 27 comments of Jan Domański

For me it was a cool way to become familiar with bazel on a small project Here the advantage could be partial re-compilation, ie incremental builds, that are notoriously flaky...

Thanks for the fixes @ianopolous Still seeing further issues running ``` bazel build --incompatible_restrict_string_escapes=false //src/peergos/shared:shared --verbose_failures ``` The output is ``` Execution platform: @local_config_platform//:host src/peergos/shared/storage/ContentAddressedStorage.java:67: error: [ArraysAsListPrimitiveArray] Arrays.asList does not...

@ianopolous moving onto the server package, things are looking good – I think it's approaching a stage where I need to declare those server-specific .jar files as explicit dependancies. This...

Thanks for fixing `PeergosFileSystemImpl.java`! This morning I found another problem ``` Execution platform: @local_config_platform//:host src/peergos/server/storage/IPFS.java:418: error: [ArraysAsListPrimitiveArray] Arrays.asList does not autobox primitive arrays, as one might expect. block.put(Arrays.asList(object)); ^ (see...

And with `IPFS.java` fixed there is (as predicable) more ... ``` Execution platform: @local_config_platform//:host src/peergos/server/storage/S3Exploration.java:27: error: [ArraysAsListPrimitiveArray] Arrays.asList does not autobox primitive arrays, as one might expect. Multihash content =...

IT WORKS!! Nice stuff Ian, thanks for mopping this up. The build passed and I'm able to run the server binary. There is however a warning about a missing .so...

Aye – will get to it as soon as i return from my well-deserved holiday trip to the remote ends of the Carpathian Mountains ⛰ (which will be in 1...

Yup, i'm on board!

I've only had a cursory look at Gromologist but i'm pretty impressed: the documentation seems really extensive, and there are tests (!!). Academic code has gotten better lately :D For...

Agreed – what could change this decision? Perhaps if it turns out that Gromologist is riddled with bugs, or otherwise hard to integrate with (has monster dependencies)