Jan Biedermann

Results 165 comments of Jan Biedermann

Make test run by default, avoid *void function cast error

Nono, its not avaoiding the warning, its avoiding the error. The error makes compilation stop. I guess this is since gcc 9 or so with -pedantic, having these casts is...

Iodine failing to compile with Ruby 3.2.0preview_2

Hi oldmoe and Bo, check here, may cherry-pick: https://github.com/boazsegev/iodine/pull/119/commits/d77a154767ab65f99e0834ea0a8d10d7b63753b9 This is for 3.1, should work for 3.2 too, but i have not tested it with 3.2 yet.

Iodine failing to compile with Ruby 3.2.0preview_2

Also needs this to compile on Windows: https://github.com/boazsegev/iodine/pull/119/commits/f5cabf27d532fdc30b70fd1fa462b6beb6f7a1dc

State Handling Performance Speedup

this doesnt work as expected with react, react seems unable to group setState calls outside of a render cycle. Preact can do this, maybe react 16 will improve this during...

while_loading / on_error redo

i still dont like it its out of place, not logic that .on replaces a render block, .on doesn't do such things

Generate and inherit from ApplicationComponent

Thats one of the first things i did, create an ApplicationComponent. It seems very natural.

Make Ruby Racer Optional

Node cant currently be used, as in prerendering hyperloop calls back into ruby rails context, which node currently cant do. But therubyracer is upgraded to mini_racer.

need way to dynamically mount components (i.e. after ajax calls)

already there: ``` React::Test::Utils.render_component_into_document(MyComponent, args) ``` maybe needs a better name

to_n on Hyperloop::Components should convert back to the js component

done in lap10, needs to be tested

to_n on Hyperloop::Components should convert back to the js component

just as above