Jan Wassenberg
Jan Wassenberg
Yes, I understand. Based on Vc's comments I think we can just add their BSD header plus yours if you want before the Atan2 function and it would be fine....
I understand :) hm, I've copied this in, implemented a test according to https://en.cppreference.com/w/cpp/numeric/math/atan2 and it looks like the code isn't yet passing. I'll send an implementation out for review...
Ah, ok. Thanks for verifying the result. We'll have the code merged soon. You're welcome! With this many special cases, it's difficult to cover them all :)
Ah, I had assumed the idea was that we define a flag so that your code knows not to define your own Atan2. Would that work for you?
Thank you @johnplatts for the guide! This sounds doable at least for manual pre-release testing. Would it be OK for you if only the released versions of Highway are known...
Thanks again @johnplatts , I was able to cross-compile and test via QEMU after setting `export QEMU_LD_PREFIX=/usr/powerpc64le-linux-gnu`. It's great to have this in, I'm marking PPC as supported and it...
Closing, feel free to reopen if you'd like to continue the discussion.
Thanks @johnplatts for implementing this :D
Thanks @johnplatts for implementing these, we now have the full set for unsigned -> unsigned/signed and signed -> signed.
I see this has been fixed 2 weeks ago in GCC ([tracker](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108681)). Per the comments there, GCC 12 is affected. I'm tempted to disable the LoadInterleaved3/4 test on GCC with...