jan-mrm

Results 29 comments of jan-mrm

yes we observed the same. It looks like that the config is not propagated to the bumper and is still uses the default without the optional "Merged PR ...". The...

I'd love to see a solution for that issue. At the moment we are using a temporary fix using `patch-package` which is not ideal. But maybe the solution from that...

It seems like that we are experiencing the same issue. Sometimes the deletion never finishes and sometimes it does finish within some minutes. We could prevent the issue by removing...

@tombuildsstuff really appreciate it. Thanks for the review and feedback (and the great work in the provider). I think I fixed all the suggestions. > jan-mrm to answer your questions:...

@stephybun thank you for the review and the updates. Done them. After writing the detailed response and reiterating over it, I think I have one more thing to fix: the...

hey, any discussion or feedback on this? 🙂

@JorTurFer I have looked at it a while ago but I didn't really understand how to use it I guess. I can take another look at it

> Overall this is looking good and ready @jan-mrm, would you still like to make the change to prevent user's having to do two applies when they update `format`? thanks,...

> I don't think the suggestion of adding a `demandsToIgnore` would scale well, because a list like this would need to be constantly updated. Using a "parent" would also not...

> As I mentioned in my edit, the `demandApproveList` would make more sense as a "global" config and would tell KEDA what demands to consider when matching and ignore anything...