Jan Fajerski

Results 36 comments of Jan Fajerski

This is a tiny (but I think worthwhile) fix, following up on #692. Hence ping @chrischdi and @FillZpp

> I'm not sure, should we keep this test to verify that annotated on both field and type, to avoid bugs like these #688 and [#693 (comment)](https://github.com/kubernetes-sigs/controller-tools/pull/693#issuecomment-1169433662) Yes that makes...

> @jan--f I don't understand what's the difference between `NestedStructWithSeveralFields` and `NestedStructWithSeveralFieldsDoubleMarked `? @FillZpp Right, because I forgot to add the field marker. Added it now, thank you! _edit_: I...

Thanks, let me try @pwittrock and @mengqiy for an `approve` then.

@paulfantom I'd appreciate if you could have a look at this if you have the time.

Yes the experiment can still be found at https://github.com/jan--f/alertmanager/tree/webhook-text-templates. This uses github.com/google/go-jsonnet 0.17, so maybe something has changed since then. Simply run `go test ./notify/webhook/ -bench . -memprofile mem.pprof -cpuprofile...

I removed the inviting tags and added a quick updated in the description. Maybe that'll help.