:sparkles: testdata/cronjob_types.go: add NestedStructWithSeveralFieldsDoubleMarked

[jan--f]

This adds a field to the cronjob test data, that ensures that fields which are marked twice (once through a type marker, one through a field marker) still generate the correct yaml structure.

Signed-off-by: Jan Fajerski [email protected]

[k8s-ci-robot]

Welcome @jan--f!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @jan--f. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jan--f]

This is a tiny (but I think worthwhile) fix, following up on #692. Hence ping @chrischdi and @FillZpp

[FillZpp]

I'm not sure, should we keep this test to verify that annotated on both field and type, to avoid bugs like these #688 and https://github.com/kubernetes-sigs/controller-tools/pull/693#issuecomment-1169433662

[jan--f]

I'm not sure, should we keep this test to verify that annotated on both field and type, to avoid bugs like these #688 and #693 (comment)

Yes that makes sense, I added a commit to that effect. WDYT?

[jan--f]

ping @FillZpp Any further concerns about this?

[FillZpp]

@jan--f I don't understand what's the difference between NestedStructWithSeveralFields and NestedStructWithSeveralFieldsDoubleMarked ?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jan--f Once this PR has been reviewed and has the lgtm label, please assign droot for approval by writing /assign @droot in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[jan--f]

@jan--f I don't understand what's the difference between NestedStructWithSeveralFields and NestedStructWithSeveralFieldsDoubleMarked ?

@FillZpp Right, because I forgot to add the field marker. Added it now, thank you!

edit: I also updated the title and PR description.

[FillZpp]

/ok-to-test

[FillZpp]

/lgtm

[jan--f]

@chrischdi anything still blocking this?

[chrischdi]

/lgtm

from my side. But requires a maintainer for approval (which I am not).

[jan--f]

Thanks, let me try @pwittrock and @mengqiy for an approve then.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jan--f Once this PR has been reviewed and has the lgtm label, please assign droot for approval by writing /assign @droot in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[alvaroaleman]

/label tide/merge-method-squash

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[alvaroaleman]

Thanks!