Jan Fajerski
Jan Fajerski
@beorn7 I think this change here looks good but #14367 needs to be approved and merged before this can go in.
Unless there is a clear functional benefit I wouldn't refactor working code just for organizational reasons.
That is perhaps a good enough argument :) I'm no expert of the `sys/` tree but iiuc whether you look in `/sys/class/net` or `/sys/bus/pci/devices/`, the files should be the same...
Or pull the `aer_*` file parsing out into a separate function and call that from `net_class_aer.go` and `pci_device.go`? If you move the parsing to a unified `/sys/bus/pci/devices/` parser you'll have...
> FYI @jan--f (sorry for pinging you directly if you're not the right person) No problem. I'm no oauth expert but perhaps my comments help?
It is entirely possible though that this new test case covers a corner case in the parser we need to fix. I reached out for more eyes on this.
Hello from the bug scrub. The link should be removed.
This updates go to 1.23 which breaks our "must build with the previous go version" policy for now.
Hello from the bug scrub. The config structure has changed slightly. This should be reproduced with a current prometheus. If the behavior is still the same, the bug is in...