James Waples

Results 103 comments of James Waples

> I'm not sure what you mean by "contiguous pixels". There's a decent explanation of mostly what I mean [here](https://lupyuen.github.io/articles/optimising-pinetimes-display-driver-with-rust-and-mynewt#8d93). I suppose you could describe it as a kind of...

Yes, it mostly happens with nearly-parallel lines. I agree that it's not a huge issue and doesn't need to block 0.7. > But I don't think that 0.7 will be...

> and a lack of motivation on my side. Likewise :c hopefully that will change soon so we can get 0.7 over the line :) Aside from the text rendering...

That was also my finding. I guess we'll know better once the cause of the issue is found, but I couldn't produce the glitch in another other than nearly straight...

Thanks for the tip! We explicitly test the chosen MSRV in CI but cargo-msrv could be useful during development for sure

Awesome! Nice work! We'd be happy to accept a PR similar to #677 to add this driver to [the list in the README](https://github.com/embedded-graphics/embedded-graphics#display-drivers).

This issue was more of a "note to self" so apologies for the vagueness. I think my approach is/was to essentially replace `fn` with `const fn` and see how much...

We might see some performance benefits when used in internal code, but I don't think it would benefit the public API to add const parameters everywhere

It will get Rustup to download 1.40.0 automatically if it's not already available when building anything in the repository. If the user isn't using Rustup I don't think it will...

> I'm unsure about this PR. Perhaps we just wait until the MSRV is bumped and specify a newer, M1 compatible, version in the toolchain file. Sure, let's go for...