James Waples

Results 103 comments of James Waples

Hit a bit of a snag trying to get a PR going for this issue. The trait should look like this, right? ```rust trait Transform { fn translate(&mut self, by:...

Do we want to put this in 0.6.0 as the last remaining breaking change, or leave the current `.translate()`/`.translate_mut()` as is?

Leave it as is for 0.6.0 and decide for 0.7.0 (or later). 0.7.0 will already get some breaking changes around fonts IIRC so, as it won't be breaking-change free, we...

> IMO this issue is related to the other geometry related issues like #156 and #182. Yeah good point. This might not happen, but it would be great to have...

Do we want to close this issue as stale now, or keep it open as additional functionality to implement? I'm not sure if the original intent is serviced by the...

Purely to reduce the amount of code duplication, would adding a blanket impl help? ```rust pub struct Point; pub trait Transform { /// Move the origin of an object by...

Hey, thanks for opening the discussion on this. I think embedded-graphics should remain target agnostic and including a framebuffer with e-g itself would go against that. It could certainly be...

@bernii has released a separate crate for framebuffer usage called [`embedded-graphics-framebuf`](https://crates.io/crates/embedded-graphics-framebuf) fwiw.

Whether a framebuffer ends up in e-g itself or is an external crate, another good use for a common framebuffer lib would be reusing more complex implementations like [this one,...

> Am I correct that the SH1106 does map bytes into 8 pixel high and 1 pixel wide columns? This would be more specialized than I intended, but it would...