James Ward

Results 233 comments of James Ward
trafficstars

Same failures with that env var.

There isn't currently an option for that but you could probably do it manually via the hooks. I'll leave this open as a feature request to add an option for...

That does seem like a bug of some sort. Maybe @glasnt can file this with the Cloud Shell team?

Can you try to remove the required key? (false is the default) Maybe the parsing of the `false` value is wrong.

Oh right. I got that backwards. I think that what might be needed to make this work is the default value which could (hopefully) be set to an empty string,...

Cloud Run Button only asks for env vars which are not already set: https://github.com/GoogleCloudPlatform/cloud-run-button/blob/master/cmd/cloudshell_open/main.go#L303-L316 It might be nice to have a param on the env var to control that behavior....

If the service exists then it will find the env var on a second run. Glad your workaround works. :)

Yeah, the env vars in Cloud Run Button are for setting env vars on Cloud Run services.

When Cloud Run Button runs the script that runs gsutil, does it exit with an error? Or does it work except without correct stdout handling?

I wonder if we can get more verbose output from your script. Also, it might be worth a small test to see how Cloud Run Button handles scripts that exit...