James Please

Results 313 comments of James Please

:+1: for uncommentify using new options

@lydell, the current solution we have in place is to make the options [mutually exclusive](https://github.com/gruntjs/grunt-contrib-concat/pull/59/files#diff-1aad213ae1c43335d1a5d0f04837d118R45). And though I wouldn't use the strip functionality myself, it seems like enough people do...

Thanks so much for looking into this! If there’s a way for me to PR adding these to the parse context I’d be happy to.

Thanks, @drgould! @shama, what do you think about processing this warning in the task to tell people to set `maxListeners` instead of `emitter.setMaxListeners()`?

heh, true, @fluxsaas, but I think the point here is we could do better than that. Grouping by type and presenting a single number for each type is a bit...

I :cupid: jscs, but at the moment this repo is pretty lightweight, being just the javascript files themselves with nothin' else. It's not a _huge_ decision, but it is a...

Thanks for the suggestions, @Maximilianos! These are definitely important skills, and I'd love to see more assessment of them in the tests. I'm curious to hear what @ashleygwilliams / @kadamwhite...

Related: https://github.com/babel/babel-library-boilerplate/pull/126

//cc @tkellen, if you ended up using this for Endpoints, then this will affect you. I have a solution that works, but just know that the problem is still outstanding...