James Please

Results 313 comments of James Please

more: https://github.com/istanbuljs/istanbul-lib-instrument/issues/4

Looks like the `babel-plugin-__coverage__` tool is working well for people. And now that it's been out for some time, so I think that'll be what I transition to.

Ha I was literally _just_ posting that @hzoo! Thanks for the link ;) --- In [this comment](https://github.com/dtinth/babel-plugin-__coverage__/issues/42#issuecomment-229069813) it's mentioned that `babel-plugin-istanbul` might be significantly slower than `__coverage__`. I'll have to...

Alright – after some investigating I'm confident that switching to [babel-plugin-istanbul](https://github.com/istanbuljs/babel-plugin-istanbul) is a good move forward.

If you build the lib, then look at the dist file, what does it appear to be exporting? You may need to adjust the tests to account for what’s exported.

Thanks @benshine ! Would you like to open a PR?

Thanks for the suggestion! Is this specifically for when the browser tests are being run? I haven't yet seen a set up that integrates linting results and test results into...

Cool. Thanks for the info! I'll definitely add this to my list of things to research. I think it would be a great addition to the boilerplate.

After some initial research this seems to be a feature that would be possible if we were to just add in Testem (thanks for looking into that @lolmaus !) to...

Good catch! I believe the require in the node setup can be removed. It must be leftover from a previous iteration. I'm planning the next release of this generator –...