generator-babel-boilerplate icon indicating copy to clipboard operation
generator-babel-boilerplate copied to clipboard

Make ESLint tests run alongside unit tests and appear in the browser report

Open lolmaus opened this issue 8 years ago • 5 comments

This is how Ember test setup does it, and it's super helpful. Lets you catch lint errors as early as possible.

lolmaus avatar Aug 21 '16 12:08 lolmaus

Thanks for the suggestion! Is this specifically for when the browser tests are being run? I haven't yet seen a set up that integrates linting results and test results into an HTML reporter. That sounds really cool, though.

Do you think you might have time to put together a PR, or otherwise link to other resources that might help get this added?

iirc Ember uses Brocolli and something other than Mocha so it may not be as easy to do here. But I'm down to add this if it's possible!

jamesplease avatar Aug 21 '16 17:08 jamesplease

Is this slecifically for when the browser tests are being run?

Yes.

Do you think you might have time to put together a PR

Nope. I'm merely a user, not familiar with test pipeline internals. Ember indeed does some non-trivial manipulation. I only know its test pipeline is based on Testem.

lolmaus avatar Aug 21 '16 17:08 lolmaus

Cool. Thanks for the info! I'll definitely add this to my list of things to research. I think it would be a great addition to the boilerplate.

jamesplease avatar Aug 21 '16 18:08 jamesplease

After some initial research this seems to be a feature that would be possible if we were to just add in Testem (thanks for looking into that @lolmaus !) to the boilerplate. It seems like it supports merging all of the results from different sources (linting, test runners like Mocha) together into 1 output.

I'll look more into how much complexity it adds to the build step. @paulfalgout, do you have any initial thoughts?

jamesplease avatar Aug 26 '16 06:08 jamesplease

oh wow. like the idea.. news to me.

paulfalgout avatar Aug 26 '16 13:08 paulfalgout