django-smartagent
django-smartagent copied to clipboard
jamespacileo
A smart and blazing fast browser feature detector for Django.
Branch `master` refactored by [Sourcery](https://sourcery.ai/github/). If you're happy with these changes, merge this Pull Request using the *Squash and merge* strategy. See our documentation [here](https://docs.sourcery.ai/GitHub/Using-Sourcery-for-GitHub/). Run Sourcery locally Reduce the...
![sourcery-ai[bot] avatar](https://avatars.githubusercontent.com/in/48477?v=4 "sourcery-ai[bot] avatar"){kind=avatar}
I think this PR doesn't need further explanation. :-)
When running unittests in a django project, with the following file: https://github.com/downloads/jamespacileo/django-smartagent/agents_2011_04_14.pkl from the following package: https://nodeload.github.com/jamespacileo/django-smartagent/tarball/master the provided unittest fails with this message: # ## FAIL: test_user_agent_recognition (smartagent.tests.BrowserDetectionTest) Traceback...
The smartagent doesn't detect Firefox 5.0.1.
The compiled patterns is great for using inside Python, but I can't give it to my boss to tell him exactly which User-Agent is considered mobile or not. Please provide...
``` python if request.browser_info['ismobiledevice']: do something ``` Will not behave as expected because it contains the string 'false', not the boolean False. If it's done for performance reasons, it should...
The most important phones on the market are now iPhones and Androids so it's a big issue. Just tested with an iPhone 3G and it didn't detect it. I had...
Metadata
Owner
Metadata
A smart and blazing fast browser feature detector for Django.