James Moss

Results 10 issues of James Moss

The current code snippets in the readme file give a good overview of how the library works but full documentation with good code examples are needed longer term.

enhancement

We should use something like https://github.com/KnpLabs/Gaufrette to abstract away file system access to make testing easier. It could also allow people to use remote filesystems like S3 (if they are...

enhancement

The `CachedQuery` doesn't have access to the `documentClass` property from the `Repository` which makes this difficult.

bug

At the moment it looks like Yosemite is inverting the light mode icon which doesn't look great. See here (compared to Dropbox's icon) ![](https://dl.dropboxusercontent.com/spa/6x2vmlqjbfp4cu0/kxj9337t.jpg)

This project has a dependency on `@babel/runtime` version `7.2.0` however Webpack 5 has enabled strict mode on ESM module imports which `7.2.0` violates and therefore won't compile. This has already...

Right now BitBucket lists out the lines added / removed per file in a PR: ![](https://cl.ly/3f1J0W1q0T23/Screen%20Shot%202018-08-13%20at%205.57.31%20pm.jpg) Github and Gitlab show totals for these numbers which gives reviewers a good idea...

feature

**Problem description** Right now it's quite easy to accidentally select the `push --force` option from the push menu. Generally you don't want to do this. **Preferred solution** Add a confirmation...

enhancement

In the `job()` method of `Worker` the json representing the job's arguments gets decoded from redis using: ``` return json_decode($job, true); ``` Passing `true` as the second parameter to `json_decode`...

The regex in `extractFileParts` is too naive and needs to include squared brackets in the filename portion.

Is this possible? I was hoping it would get passed in as a parameter to the callback but this isn't the case.