James Mills

Results 43 comments of James Mills

OK, turns out it always returns tablet as mobile. So you have to switch the logic to ``` if ($agent->isTablet()) { return 'Tablet'; } elseif ($agent->isMobile()) { return 'Mobile'; }...

I would have thought many would want to know if the device is tablet, phone or desktop. Would it be helpful to have something in the package to do something...

Hi @divdax I love this idea, thanks for your suggestion. Is this something you would be willing to submit a PR for?

@divdax I actually liked your idea of ``` --update optional. Generate uuids for all rows. ``` What we might have to do is look to see if we are adding...

Hi Ben, Thanks for your speedy reply! We are going to be using the "Using Translation Strings As Keys" found in the docs on this page https://laravel.com/docs/5.8/localization#defining-translation-strings quite a lot....

Looks like this package does the .json files too https://github.com/tanmuhittin/laravel-google-translate

So it looks like in the `scrip.blade.php` file if you add the sparkline enabled flag this automatically works. ``` chart: { type: '{!! $chart->type() !!}', ... foreColor: '{!! $chart->foreColor() !!}',...

@ArielMejiaDev if I look at PR'ing this would it make it into prod or would we have to wait for a new version?

@eina84 you just need to wait until this package has been updated to work with Laravel 9. There is a PR by @ArielMejiaDev open for this https://github.com/ArielMejiaDev/larapex-charts/pull/51