James Koster
James Koster
@mirka or @ciampo do you know why the tests are failing? ðŸ˜
I enabled auto-merge. We're very early in the release cycle so there's plenty of time to gather additional design feedback and refine as required.
@richtabor I had the same thought, but when I tried it the help text appeared to be attached to the last radio in the group. There's an issue here about...
Thanks for pointing that out, definitely not intended. I'll work on a fix.
Another consideration; when a tab panel is the first child in an element that has padding it can look a little strange: It would be good to explore options whereby...
I think we can use the designs from https://github.com/WordPress/gutenberg/issues/41904#issuecomment-1165341454 here. And to answer my own questions in the OP: > Should there be a border beneath the tabs as a...
Making the settings/appearance tabs `sticky` is worth exploring, similar to blocks/patterns/media in the Inserter. I don't know that it needs to be a specific prop on the component though, it...
> Another way around it could be to make the nested tabpanel a separate scrolling container, but that's probably not a silver bullet either I misread this to mean individually...
It's a shame the text alignment icons weren't namespaced 😅 Do you think it would make sense to name these icons so that they're grouped with the other 'justify...' ones?...
Yes that makes sense to me :)