James Koster
James Koster
I made a quick prototype to demonstrate the animation and scroll behavior. The animation is based on the Snackbar component. https://github.com/WordPress/gutenberg/assets/846565/491a16c3-46df-4cb4-a269-c27955c27655 Appreciate the animation may be tricky to replicate if...
@jorgefilipecosta thanks for the updates! I pushed some style adjustments – in terms of design we're looking pretty good. One observation; I'm only seeing the toolbar on the pages data...
@jorgefilipecosta one other observation: when you view Trash, select an item, and click "Restore" in the toolbar there's a brief flash of different actions before the toolbar disappears. You can...
Thanks for the update :) I see the toolbar on the Templates page, but not the Patterns page. For Patterns, 'Delete' and 'Export as json' should be available as bulk...
This is working better with the frozen modal, thanks for working on it! Could we also try adding the `isBusy` prop to the button? On a similar train of thought;...
Thanks @jorgefilipecosta, it's close now! The busy prop is working well for actions without a confirmation modal. But when there's a confirmation modal (e.g. trashing) it's the button in the...
> Would you prefer them to be just shown on the modal? Yeah, if it's possible? 🙏 I think it will be less distracting.
Thanks @jorgefilipecosta, it's working well now. I think the last thing to tweak before getting wider feedback is the busy state on the toolbar buttons. It's a bit strange how...
Pushed some adjustments. I see one remaining issue. On the templates page, the actions in the toolbar are inconsistent with the actions in the menu. In the screenshot below notice...
Thanks @jorgefilipecosta, very close now! I noticed there's a small bug with the template delete action when invoked from the toolbar, it seems to do both; reset _and_ delete. To...