James Kerr

Results 115 comments of James Kerr

Yeah that makes sense. I thing once you switch to the keyboard drag mode, the drop cursor (blue line) would go up and down with the relevant arrows. Maybe it...

Yeah I suppose that would be a good order to do things. I'll write out my thoughts about the configurable bindings in #57

Thanks for bring this up again. I'll put this on the feature list for the next major version.

@GermanJablo those react-aria libraries look very promising. I would like to replace react-dnd soon.

Thank you @boriskor ! This looks really good. I am testing it out now.

I am noticing some bugs when using shift + up/down to expand the selection with the keyboard.

It looks like you may need to keep the the anchor and the most recent the same, even if some of the items are not selected. Maybe this means you...

Here are some videos of the behavior I am seeing on your branch. **Shift+Up/Down with selectable nodes (base behavior)** https://github.com/brimdata/react-arborist/assets/3460638/d0b10331-3460-446c-8a86-9a8130d481ae **Shift+Up/Down Encountering a non-selectable node (bug)** https://github.com/brimdata/react-arborist/assets/3460638/ec508519-fa69-445f-bb8a-f173db36752b To me, it's...

Not currently. I'd need to change the dnd engine to support this. What does it do now? Totally not work?

That's a good idea. Thanks for the suggestion. I think it would also be good to put in the TreeApi as a method. We currently have an `.isFiltered` boolean getter....