James Hilliard

Results 285 comments of James Hilliard

> Just bumping this again. Would really like this stabilized so I can get off of nightly builds. :) Not sure what status of stabilizing this is, but if you...

> TARGET_CC and CC might work for compiling, to distinguish between build scripts and the cross-compiled binaries/libs, but the same linker is being used to build the build scripts as...

> I am surprised that these don't both have the same value, is that a mistake? : Should be correct, see: [`CARGO_UNSTABLE_TARGET_APPLIES_TO_HOST="true"`](https://github.com/buildroot/buildroot/blob/2022.11-rc1/package/pkg-cargo.mk#L35-L36) [`CARGO_TARGET_APPLIES_TO_HOST="false"`](https://github.com/buildroot/buildroot/blob/2022.11-rc1/package/pkg-cargo.mk#L38-L40) > For stable, if I set the...

> Unfortunately, ZXing is Apache licensed. For us, the better would be either if someone with time could finish the implementation from scratch or if we could use some code...

Possibly related boot issue I'm seeing: ``` 12-13 11:45:36.462 5602 5602 E System : ****************************************** 12-13 11:45:36.462 5602 5602 E System : ************ Failure starting system services 12-13 11:45:36.462 5602...

> Please remove the `[GStreamer]` prefix, this code is port-agnostic. Removed > Also, why `Media` and not `MediaStream` ? Seems `LogMedia` is what's being used in other places for `MediaStream`,...

> Please change all of these to `MediaStream`. Should it be `MediaStream` or `LogMediaStream`?

> @jameshilliard @mksh Would it be fair to say that #267 supersedes this? I went ahead and merged trunk into the changes made in #267 and fixed the merge conflicts/tests.

> @jameshilliard this looks pretty good but a lot of these methods are missing type annotations. Can you add those in? Sure, will work on that and update.