James Hilliard

> Dereferencing occurs only at compile time to get the size of the struct So should maybe change it to something like this then?: ```c struct mg_rpc *rpc = (struct...

For reference the analysis of coverity looks like this: ```c 3540void mg_rpc_add(struct mg_rpc **head, struct mg_str method, 3541 void (*fn)(struct mg_rpc_req *), void *fn_data) { ``` > 1. **returned_null: calloc...

> sizeof(*TYPE) resolves to a correct value regardless of the allocation result . > If that's what a static analyzer complains about , then it is a static analyzer should...

> As the function is called with new_size=0, dereferencing occurs in zeromem(), which checks for null, and free(), which is safe. I don't think that's what it's complaining about: ```c...

Seeing a whole bunch of [build failures](http://autobuild.buildroot.net/?reason=protobuf-3.20.1) related to this with [buildroot's](https://buildroot.org/)(linux cross compilation toolkit) autobuilders on a few different architectures.

hack to bypass the issue: ```diff diff --git a/platform/wayland/cog-platform-wl.c b/platform/wayland/cog-platform-wl.c index ec76a08..a1a4e9e 100644 --- a/platform/wayland/cog-platform-wl.c +++ b/platform/wayland/cog-platform-wl.c @@ -61,8 +61,8 @@ #include #endif -#define DEFAULT_WIDTH 1024 -#define DEFAULT_HEIGHT 768 +#define...

> This seems to be a race. I did come across some workarounds for what may be the same issue in sdl2: https://github.com/libsdl-org/SDL/commit/48917e0e709d0f8efb7a0c476bb96652e1dd4ba3 https://github.com/libsdl-org/SDL/commit/ea28187cd5edf7b49fc9b9e866c6497a161b1da2

It would seem this fix is causing a crash when used with postgres

I made a new test store and it would appear there is some sort of conflict with the spree_fancy theme https://github.com/spree/spree_fancy

Seems I was having issues with products in cart blocking currency change. At least if those products didn't have an alternate currency set.