James Brock

Results 280 comments of James Brock

> I also found a small error in the Multi-threaded Sending section of the readme.md file. Thanks!

> But, `std::string_view::begin` and `std::string_view::end` return `std::basic_string_view` instead of `const char*` They return a `std::basic_string_view::const_iterator` which will be type `const char *`. Or is it not type `const char *`...

I don't have easy access to a Windows machine so it's inconvenient for me to write a fix for this because I can't test it on Windows. Would you like...

> Yes, I will be happy to do PR. Yes please, that looks good. https://en.cppreference.com/w/cpp/string/basic_string_view/data Do you know how to open a Pull Request? https://github.com/jamesdbrock/hffix/pulls

Please explain further? How is `next_message_reader` supposed to behave after this PR? Honestly, this whole business with automatically searching for the next `8=FIX` string after an invalid message was probably...

If there is no valid message in the rest of the buffer, then we don't know where the last byte is. That's why the `message_reader::end()` says > `std::logic_error` if called...

Hm maybe `Control.Monad.Error` has been removed from `base`.

Yeah this text seems a bit outdated.

We should hook https://github.com/haskell/haskell-ide-engine up to IHaskell.

It looks like __tweag/jupyterWith__ is currently pinned to the last commit which bumped the cabalfile version. https://github.com/gibiansky/IHaskell/commit/e15dd63d2efdcfda599dc022732b33589005a6d5 https://github.com/tweag/jupyterWith/blob/7a6716f0c0a5538691a2f71a9f12b066bce7d55c/nix/haskell-overlay.nix#L7 Maybe time for another version bump and a hackage release? I also...